Feature (Light Edges / 2) - refactor(storage): carry Edge* in deleted_edges_ instead of Gid#4209
Draft
andrejtonev wants to merge 1 commit into
Draft
Conversation
GC already holds the Edge* during the delta walk; recording the Gid and re-find()-ing the pointer at removal time is redundant. Carry the Edge* through the deleted-edge working set (deleted_edges_, current_deleted_edges, my_deleted_edges) and drop the find() round-trip in the vector-edge-index cleanup. EdgeMetadataIndex still keys on Gid, so its OnEdgesDeleted call sites project via views::transform(&Edge::gid). Master's metadata -> vertices -> edges removal ordering and the MG_ASSERT(edge_acc.remove(...)) invariant are preserved. Heavy-mode behaviour-preserving; introduces no light-edge logic.
Contributor
Author
|
Git commit description, explain the changes you made here Leave above in PR description, copy the below into a comment Tracking
Standard development
CI Testing Labels
Documentation checklist
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC already holds the Edge* during the delta walk; recording the Gid and re-find()-ing the pointer at removal time is redundant. Carry the Edge* through the deleted-edge working set (deleted_edges_, current_deleted_edges, my_deleted_edges) and drop the find() round-trip in the vector-edge-index cleanup. EdgeMetadataIndex still keys on Gid, so its OnEdgesDeleted call sites project via views::transform(&Edge::gid). Master's metadata -> vertices -> edges removal ordering and the MG_ASSERT(edge_acc.remove(...)) invariant are preserved.
Heavy-mode behaviour-preserving; introduces no light-edge logic.