Feature (Light Edges / 1) - refactor(storage): thread EdgeRef through edge-type-index abort path#4207
Draft
andrejtonev wants to merge 1 commit into
Draft
Feature (Light Edges / 1) - refactor(storage): thread EdgeRef through edge-type-index abort path#4207andrejtonev wants to merge 1 commit into
andrejtonev wants to merge 1 commit into
Conversation
The edge-type-index abort path collected raw Edge* for cleanup. Threading EdgeRef instead lets the same abort machinery describe both heavy (skiplist-resident) and light (pool-allocated) edges by gid-or-pointer, which a later light-edge PR requires. In isolation this is behaviour-preserving: the abort collection is a std::vector iterated linearly, never sorted or keyed on EdgeRef, so EdgeRef's gid-based comparators are never exercised; every EdgeRef originates from an Edge* so .ptr is the active union member end-to-end, and the index consumer extracts .edge = edge.ptr exactly as before. The two caller sites (InMemoryStorage detach-delete producer and InMemoryEdgeTypeIndex::AbortEntries consumer) are updated in the same commit because EdgeRef's constructor and Entry::edge are both non-implicit, so the change does not compile piecemeal.
Contributor
Author
|
Git commit description, explain the changes you made here Leave above in PR description, copy the below into a comment Tracking
Standard development
CI Testing Labels
Documentation checklist
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edge-type-index abort path collected raw Edge* for cleanup. Threading EdgeRef instead lets the same abort machinery describe both heavy (skiplist-resident) and light (pool-allocated) edges by gid-or-pointer, which a later light-edge PR requires. In isolation this is behaviour-preserving: the abort collection is a std::vector iterated linearly, never sorted or keyed on EdgeRef, so EdgeRef's gid-based comparators are never exercised; every EdgeRef originates from an Edge* so .ptr is the active union member end-to-end, and the index consumer extracts .edge = edge.ptr exactly as before.