fix: typo CommitedTransactions → CommittedTransactions#4150
Open
algojogacor wants to merge 3 commits into
Open
fix: typo CommitedTransactions → CommittedTransactions#4150algojogacor wants to merge 3 commits into
algojogacor wants to merge 3 commits into
Conversation
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2103
The string
CommitedTransactions(missing a 't') appears in 3 files across the codebase. This PR corrects all occurrences toCommittedTransactions.Root Cause
The typo
CommitedTransactionswas used as a metric/label name in the event counter C++ source and two Python test files. The correct spelling isCommittedTransactionswith a double 't', consistent with the standard spelling of "committed."Fix
Replaced all occurrences of
CommitedTransactionswithCommittedTransactionsin 3 files:src/utils/event_counter.cpptests/e2e/show_metrics/show_metrics.pytests/e2e/show_metrics/show_metrics_json_values.pyChanges
src/utils/event_counter.cpp: fix metric name typo (+1 -1)tests/e2e/show_metrics/show_metrics.py: fix metric name typo (+1 -1)tests/e2e/show_metrics/show_metrics_json_values.py: fix metric names typo (+2 -2)Testing
show_metrics.py: same string, test assertions unchanged ✅show_metrics_json_values.py: same string, test assertions unchanged ✅