Clarify behavior of client.url#43844
Merged
Merged
Conversation
Contributor
|
Preview URLs (2 pages) (comment last updated: 2026-05-29 15:21:07) |
Collaborator
Author
|
@chrisdavidmills , can I get a review of this? |
chrisdavidmills
approved these changes
May 29, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @wbamberg. Just one language nit to sort out; approving so you can merge once that's done.
|
|
||
| ### Opening a window on a notification click | ||
|
|
||
| In this example a service worker creates and then shows a that contains an associated URL, which is under the service worker's scope. When the user clicks the notification: |
Contributor
There was a problem hiding this comment.
"...shows a that..." - something missing here, but I'm not sure what.
wbamberg
commented
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41483, fixes #41482.
At least that's the idea.
My understanding of this, mostly from testing, is that Client.url isn't updated unless an actual page load happens, which means it isn't updated in situations such as:
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2Fmdn%2Fcontent%2Fpull%2F43844%23thing%26gt%3Bgo+to+thing%26lt%3B%2Fa%26gt%3B%3C%2Fcode%3E%3C%2Fli%3E%0A%3Cli%3Ethe+web+app+is+an+SPA+that+intercepts+navigation+events+%28for+example%2C+using+the+Navigation+API%29+and+updates+the+page+content+using+client-side+JavaScript%3C%2Fli%3E%0A%3C%2Ful%3E%0A%3Cp+dir%3D"auto">This is unituitive, partly because the value ofClient.urlwould in these cases not matchdocument.location.hrefor the URL bar.I've tested this, and have tried to express it. I'm not sure what the best language to use here is though.
Side note, the Navigation API docs are lacking any guide docs. I had to read https://developer.chrome.com/docs/web-platform/navigation-api to understand how to use it, and that guide although good is quite out of date.