Skip to content

test: improve the Graph tests #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 3 commits into from
May 3, 2025
Merged

test: improve the Graph tests #797

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c3ba0c
test: improve the Graph tests
tbouffard May 2, 2025
90c4947
Add tests to check custom EdgeStyle implementations
tbouffard May 3, 2025
7dce46c
Add more expect
tbouffard May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions packages/core/__tests__/view/Graph.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,52 +17,63 @@ limitations under the License.
import { describe, expect, test } from '@jest/globals';
import {
AbstractGraph,
BaseGraph,
Cell,
CellState,
EdgeHandler,
EdgeSegmentHandler,
EdgeStyle,
type EdgeStyleFunction,
ElbowEdgeHandler,
Point,
Rectangle,
RectangleShape,
VertexHandler,
} from '../../src';
import { createGraphWithoutPlugins } from '../utils';

const customEdgeStyle: EdgeStyleFunction = () => {
// do nothing, we just need a custom implementation that is not registered by default
};

describe('isOrthogonal', () => {
test('Style of the CellState, orthogonal: true', () => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = new CellState(graph.view, null, { orthogonal: true });
expect(graph.isOrthogonal(cellState)).toBeTruthy();
});

test('No style in the CellState', () => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
expect(graph.isOrthogonal(new CellState())).toBeFalsy();
});

test.each([undefined, null])('Style of the CellState, orthogonal: %s', (orthogonal) => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = new CellState(graph.view, null, { orthogonal });
expect(graph.isOrthogonal(cellState)).toBeFalsy();
});

test.each([
['EntityRelation', EdgeStyle.EntityRelation],
['ElbowConnector', EdgeStyle.ElbowConnector],
['ManhattanConnector', EdgeStyle.ManhattanConnector],
['OrthogonalConnector', EdgeStyle.OrthConnector],
['SegmentConnector', EdgeStyle.SegmentConnector],
['SideToSide', EdgeStyle.SideToSide],
['TopToBottom', EdgeStyle.TopToBottom],
])('Style of the CellState, edgeStyle: %s', (_name, edgeStyle) => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = new CellState(graph.view, null, { edgeStyle });
expect(graph.isOrthogonal(cellState)).toBeTruthy();
});

test('Style of the CellState, edgeStyle: Loop', () => {
const graph = createGraphWithoutPlugins();
test.each([
['custom', customEdgeStyle],
['Loop', EdgeStyle.Loop],
])('Style of the CellState, edgeStyle: %s', (_name, edgeStyle) => {
const graph = new BaseGraph();
const cellState = new CellState(graph.view, null, {
edgeStyle: EdgeStyle.Loop,
edgeStyle: edgeStyle,
});
expect(graph.isOrthogonal(cellState)).toBeFalsy();
});
Expand All @@ -85,7 +96,7 @@ describe('createEdgeHandler', () => {
['SideToSide', EdgeStyle.SideToSide],
['TopToBottom', EdgeStyle.TopToBottom],
])('Expect ElbowEdgeHandler for edgeStyle: %s', (_name, edgeStyle) => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = createCellState(graph, true);
expect(graph.createEdgeHandler(cellState, edgeStyle)).toBeInstanceOf(
ElbowEdgeHandler
Expand All @@ -97,32 +108,36 @@ describe('createEdgeHandler', () => {
['OrthogonalConnector', EdgeStyle.OrthConnector],
['SegmentConnector', EdgeStyle.SegmentConnector],
])('Expect EdgeSegmentHandler for edgeStyle: %s', (_name, edgeStyle) => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = createCellState(graph, true);
expect(graph.createEdgeHandler(cellState, edgeStyle)).toBeInstanceOf(
EdgeSegmentHandler
);
});

test.each([
['custom', customEdgeStyle],
['EntityRelation', EdgeStyle.EntityRelation],
['null', null],
])('Expect EdgeHandler for edgeStyle: %s', (_name, edgeStyle) => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = createCellState(graph, true);
expect(graph.createEdgeHandler(cellState, edgeStyle)).toBeInstanceOf(EdgeHandler);
const edgeHandler = graph.createEdgeHandler(cellState, edgeStyle);
expect(edgeHandler).toBeInstanceOf(EdgeHandler);
expect(edgeHandler).not.toBeInstanceOf(EdgeSegmentHandler);
expect(edgeHandler).not.toBeInstanceOf(ElbowEdgeHandler);
});
});

describe('createHandler', () => {
test('Expect VertexHandler', () => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = createCellState(graph, false);
expect(graph.createHandler(cellState)).toBeInstanceOf(VertexHandler);
});

test('Expect EdgeHandler', () => {
const graph = createGraphWithoutPlugins();
const graph = new BaseGraph();
const cellState = createCellState(graph, true);
expect(graph.createHandler(cellState)).toBeInstanceOf(EdgeHandler);
});
Expand Down