Skip to content

feat: let efficiently not load default plugins and style builtins [POC] #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tbouffard wants to merge 4 commits into from
Closed

feat: let efficiently not load default plugins and style builtins [POC] #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f73adef
feat: let efficiently not load default plugins and style builtins [POC]
tbouffard Apr 7, 2025
9d1ae40
update package-lock.json: add new examples
tbouffard Apr 8, 2025
4bf1d07
Graph.ts: restore original file header [skip ci]
tbouffard Apr 8, 2025
ad54125
fix TSC errors in stories
tbouffard Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,16 @@ jobs:
run: npm test -w packages/ts-support
- name: Build ts-example (custom shapes)
run: npm run build -w packages/ts-example
- name: Build ts-example (selected features)
run: npm run build -w packages/ts-example-selected-features
- name: Build ts-example (without defaults)
run: npm run build -w packages/ts-example-without-defaults
- name: Build Storybook mini-site
run: npm run build -w packages/html
- name: Build js-example
run: npm run build -w packages/js-example
- name: Build js-example (selected features)
run: npm run build -w packages/js-example-selected-features
- name: Build js-example (without defaults)
run: npm run build -w packages/js-example-without-defaults
- name: Upload all examples as artifact
Expand All @@ -71,10 +75,8 @@ jobs:
name: examples-${{runner.os}}-${{github.sha}}
path: |
packages/html/dist/
packages/js-example/dist/
packages/js-example-without-defaults/dist/
packages/ts-example/dist/
packages/ts-example-without-defaults/dist/
packages/js-example*/dist/
packages/ts-example*/dist/
- name: Ensure no circular dependencies in the @maxgraph/core produced JS files
run: npm run check:circular-dependencies -w packages/core
- name: Ensure no lint errors
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ Note that they are based on `maxGraph` features, which require the use of [CSS a
- The stories are currently written in `JavaScript` and will be progressively migrated to `TypeScript`.
- A live instance is available on the [maxGraph website](https://maxgraph.github.io/maxGraph/demo).
- the [ts-example](packages/ts-example) project/application that demonstrates how to define and use custom `Shapes` with `maxGraph`. It is a vanilla TypeScript application built by [Vite](https://vitejs.dev/).
- the [ts-example-selected-features](packages/js-example-without-defaults) project/application that demonstrates how to use select some features (use related plugins only) and how to only register specific style defaults. It is a vanilla JavaScript application built by [Webpack](https://webpack.js.org/).
- the [ts-example-without-defaults](packages/ts-example-without-defaults) project/application that demonstrates how to not use defaults plugins and style defaults (shapes, perimeters, ...). It is a vanilla TypeScript application built by [Vite](https://vitejs.dev/).
- the [js-example](packages/js-example) project/application that demonstrates how to import and export the `maxGraph` model with XML data. It is a vanilla JavaScript application built by [Webpack](https://webpack.js.org/).
- the [js-example-without-defaults](packages/js-example-without-defaults) project/application that demonstrates how to not use defaults plugins and style defaults (shapes, perimeters, ...). It is a vanilla JavaScript application built by [Webpack](https://webpack.js.org/).
Expand Down
Loading