feat(examples): activate the storybook source addon - #75
Merged
Conversation
This replicates what mxgraph examples previously provided: the source code directly accessible within the example. It allows copy/paste for reuse in user applications and should improve the adoption. The code used to manage the controls is easily identifiable and can help highlight certain parts of the example (ContextMenu, RubberBand, ...). Also bump storybook from 6.4.0 to 6.4.13.
tbouffard
force-pushed
the
chore/display_story_source_in_UI
branch
from
January 21, 2022 09:39
3876416 to
39a2862
Compare
tbouffard
marked this pull request as ready for review
January 21, 2022 09:40
|
I was searching for a while whether adding source previews was possible, just must not have been looking hard enough - this will be a significant improvement. |
mcyph
approved these changes
Jan 22, 2022
junsikshim
approved these changes
Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replicates what mxgraph examples previously provided: the source code directly accessible within the example.
It allows copy/paste for reuse in user applications and should improve the adoption.
The code used to manage the controls is easily identifiable and can help highlight certain parts of the example (ContextMenu, RubberBand, ...).
Also bump storybook from 6.4.0 to 6.4.13.
Description for the changelog
Storybook examples let see the example source code for easier reuse.
Other info
storybook_source-addon_in_action.mp4
Possible Alternatives