Skip to content

refactor: do not redeclare ImageShape properties already in Shape #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 1 commit into from
Feb 26, 2025
Merged

refactor: do not redeclare ImageShape properties already in Shape #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/view/geometry/Shape.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ import { StyleDefaultsConfig } from '../../util/config';
* ```
*/
class Shape {
// Assigned in mxCellRenderer
/**
* Switch to preserve image aspect.
* @default false
*/
preserveImageAspect = false;
overlay: CellOverlay | null = null;
indicator: Shape | null = null;
Expand Down
14 changes: 1 addition & 13 deletions packages/core/src/view/geometry/node/ImageShape.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import RectangleShape from './RectangleShape';
import type Rectangle from '../Rectangle';
import CellState from '../../cell/CellState';
import type AbstractCanvas2D from '../../canvas/AbstractCanvas2D';
import CellOverlay from '../../cell/CellOverlay';
import { NONE } from '../../../util/Constants';
import { ColorValue } from '../../../types';

Expand All @@ -42,23 +41,12 @@ class ImageShape extends RectangleShape {

this.imageSrc = imageSrc;
this.shadow = false;
this.preserveImageAspect = true;
}

// TODO: Document me!!
shadow: boolean;

imageSrc: string;

// Used in mxCellRenderer
overlay: CellOverlay | null = null;

/**
* Switch to preserve image aspect. Default is true.
* @default true
*/
// preserveImageAspect: boolean;
preserveImageAspect = true;

/**
* Disables offset in IE9 for crisper image output.
*/
Expand Down