Skip to content

fix: ensure that codecs for base JS elements are registered #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 1 commit into from
Jan 3, 2025
Merged

fix: ensure that codecs for base JS elements are registered #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/core/src/serialization/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ import StyleChange from '../view/undoable_changes/StyleChange';
import ValueChange from '../view/undoable_changes/ValueChange';
import VisibleChange from '../view/undoable_changes/VisibleChange';

let isBaseCodecsRegistered = false;
const registerBaseCodecs = (force = false) => {
if (!isBaseCodecsRegistered || force) {
CodecRegistry.register(new ObjectCodec({})); // Object
CodecRegistry.register(new ObjectCodec([])); // Array

isBaseCodecsRegistered = true;
}
};

const registerGenericChangeCodecs = () => {
const __dummy: any = undefined;
CodecRegistry.register(
Expand Down Expand Up @@ -88,8 +98,7 @@ export const registerModelCodecs = (force = false) => {
// Codecs are currently only registered automatically during encode/export
CodecRegistry.register(createObjectCodec(new Geometry(), 'Geometry'));
CodecRegistry.register(createObjectCodec(new Point(), 'Point'));
CodecRegistry.register(new ObjectCodec({})); // Object
CodecRegistry.register(new ObjectCodec([])); // Array
registerBaseCodecs(force);

// mxGraph support
CodecRegistry.addAlias('mxGraphModel', 'GraphDataModel');
Expand Down Expand Up @@ -136,6 +145,8 @@ let isEditorCodecsRegistered = false;
*/
export const registerEditorCodecs = (force = false) => {
if (!isEditorCodecsRegistered || force) {
registerBaseCodecs(force);

CodecRegistry.register(new EditorCodec());
CodecRegistry.register(new EditorKeyHandlerCodec());
CodecRegistry.register(new EditorPopupMenuCodec());
Expand Down