Skip to content

fix(story): convert page-breaks story to typescript and add missing imports #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbouffard merged 3 commits into from
Sep 23, 2024
Merged

fix(story): convert page-breaks story to typescript and add missing imports #537

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d10182e
change extension of pagebreak story from js to ts
reuse-ay Sep 21, 2024
14f466d
fix PageBreaks.story.ts error
reuse-ay Sep 21, 2024
5b3ef8e
Remove extra break lines
tbouffard Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions packages/html/stories/PageBreaks.stories.js → packages/html/stories/PageBreaks.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ import {
RubberBandHandler,
DomHelpers,
InternalEvent,
SelectionHandler,
constants,
PrintPreview,
domUtils,
} from '@maxgraph/core';

import {
Expand Down Expand Up @@ -49,7 +53,7 @@ export default {
},
};

const Template = ({ label, ...args }) => {
const Template = ({ label, ...args }: Record<string, string>) => {
const div = document.createElement('div');
const container = createGraphContainer(args);
div.appendChild(container);
Expand All @@ -72,7 +76,7 @@ const Template = ({ label, ...args }) => {
// Removes header and footer from page height
graph.pageFormat.height -= headerSize + footerSize;

const graphHandler = graph.getPlugin('SelectionHandler');
const graphHandler = graph.getPlugin<SelectionHandler>('SelectionHandler');

// Takes zoom into account for moving cells
graphHandler.scaleGrid = true;
Expand All @@ -96,33 +100,33 @@ const Template = ({ label, ...args }) => {
280,
330
);
const e1 = graph.insertEdge(parent, null, '', v1, v2);
graph.insertEdge(parent, null, '', v1, v2);
});

const buttons = document.createElement('div');
div.appendChild(buttons);

buttons.appendChild(
DomHelpers.button('Toggle Page Breaks', function (evt) {
DomHelpers.button('Toggle Page Breaks', function (_evt) {
graph.pageBreaksVisible = !graph.pageBreaksVisible;
graph.sizeDidChange();
})
);

buttons.appendChild(
DomHelpers.button('Zoom In', function (evt) {
DomHelpers.button('Zoom In', function (_evt) {
graph.zoomIn();
})
);

buttons.appendChild(
DomHelpers.button('Zoom Out', function (evt) {
DomHelpers.button('Zoom Out', function (_evt) {
graph.zoomOut();
})
);

buttons.appendChild(
DomHelpers.button('Print', function (evt) {
DomHelpers.button('Print', function (_evt) {
// Matches actual printer paper size and avoids blank pages
const scale = 0.5;

Expand All @@ -148,7 +152,7 @@ const Template = ({ label, ...args }) => {

const oldRenderPage = preview.renderPage;
preview.renderPage = function (w, h, x, y, content, pageNumber) {
const div = oldRenderPage.apply(this, arguments);
const div = oldRenderPage.apply(this, [w, h, x, y, content, pageNumber]);

const header = document.createElement('div');
header.style.position = 'absolute';
Expand All @@ -164,18 +168,18 @@ const Template = ({ label, ...args }) => {
// Vertical centering for text in header/footer
header.style.lineHeight = `${this.marginTop - 10}px`;

const footer = header.cloneNode(true);
const footer = header.cloneNode(true) as HTMLDivElement;

write(header, `Page ${pageNumber} - Header`);
domUtils.write(header, `Page ${pageNumber} - Header`);
header.style.borderBottom = '1px solid gray';
header.style.top = '0px';

write(footer, `Page ${pageNumber} - Footer`);
domUtils.write(footer, `Page ${pageNumber} - Footer`);
footer.style.borderTop = '1px solid gray';
footer.style.bottom = '0px';

div.firstChild.appendChild(footer);
div.firstChild.appendChild(header);
div.firstChild?.appendChild(footer);
div.firstChild?.appendChild(header);

return div;
};
Expand All @@ -185,7 +189,7 @@ const Template = ({ label, ...args }) => {
);

buttons.appendChild(
DomHelpers.button('Reset View', function (evt) {
DomHelpers.button('Reset View', function (_evt) {
graph.view.scaleAndTranslate(0.15, 0, 0);
})
);
Expand Down