Skip to content

chore: measure impact of the Edge and Vertex Handlers on tree-shaking [POC] #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tbouffard wants to merge 5 commits into from
Closed

chore: measure impact of the Edge and Vertex Handlers on tree-shaking [POC] #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7609e82
START simulate no VertexHandler
tbouffard Jun 9, 2024
7b9238e
Revert "START simulate no VertexHandler"
tbouffard Jun 9, 2024
536416a
START simulate no EdgeHandler
tbouffard Jun 9, 2024
de8a868
Revert "START simulate no EdgeHandler"
tbouffard Jun 9, 2024
7a4b4a6
START simulate both no EdgeHandler and no VertexHandler
tbouffard Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export { default as PopupMenuHandler } from './view/handler/PopupMenuHandler';
export { default as RubberBandHandler } from './view/handler/RubberBandHandler';
export { default as SelectionCellsHandler } from './view/handler/SelectionCellsHandler';
export { default as TooltipHandler } from './view/handler/TooltipHandler';
export { default as VertexHandler } from './view/handler/VertexHandler';
export type { default as VertexHandler } from './view/handler/VertexHandler';

export { default as CircleLayout } from './view/layout/CircleLayout';
export { default as CompactTreeLayout } from './view/layout/CompactTreeLayout';
Expand Down
22 changes: 13 additions & 9 deletions packages/core/src/view/Graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ class Graph extends EventSource {
createEdgeHandlerInstance(state: CellState): EdgeHandler {
// Note this method not being called createEdgeHandler to keep compatibility
// with older code which overrides/calls createEdgeHandler
return new EdgeHandler(state);
// return new EdgeHandler(state);
return null!;
}

/**
Expand All @@ -439,7 +440,8 @@ class Graph extends EventSource {
* @param state {@link CellState} to create the handler for.
*/
createEdgeSegmentHandler(state: CellState) {
return new EdgeSegmentHandler(state);
// return new EdgeSegmentHandler(state);
return null;
}

/**
Expand All @@ -448,7 +450,8 @@ class Graph extends EventSource {
* @param state {@link CellState} to create the handler for.
*/
createElbowEdgeHandler(state: CellState) {
return new ElbowEdgeHandler(state);
// return new ElbowEdgeHandler(state);
return null;
}

/**
Expand Down Expand Up @@ -485,7 +488,8 @@ class Graph extends EventSource {
* @param state {@link CellState} to create the handler for.
*/
createVertexHandler(state: CellState): VertexHandler {
return new VertexHandler(state);
// return new VertexHandler(state);
return null!;
}

// ===================================================================================================================
Expand Down Expand Up @@ -1037,24 +1041,24 @@ class Graph extends EventSource {
* @param edgeStyle the {@link EdgeStyleFunction} that let choose the actual edge handler.
*/
createEdgeHandler(state: CellState, edgeStyle: EdgeStyleFunction | null): EdgeHandler {
let result = null;
const result = null;
if (
edgeStyle == EdgeStyle.Loop ||
edgeStyle == EdgeStyle.ElbowConnector ||
edgeStyle == EdgeStyle.SideToSide ||
edgeStyle == EdgeStyle.TopToBottom
) {
result = this.createElbowEdgeHandler(state);
// result = this.createElbowEdgeHandler(state);
} else if (
edgeStyle == EdgeStyle.SegmentConnector ||
edgeStyle == EdgeStyle.OrthConnector
) {
result = this.createEdgeSegmentHandler(state);
// result = this.createEdgeSegmentHandler(state);
} else {
result = this.createEdgeHandlerInstance(state);
// result = this.createEdgeHandlerInstance(state);
}

return result;
return result!;
}

/*****************************************************************************
Expand Down
Loading