fix: correctly detect parent in SwimlaneMixin.dropTarget - #390
Merged
Conversation
The target was not detected as a valid target so, the targeted swimlane was never highlighted while panning the cell over the potential target. The problem was visible in the Swimlanes and Folding stories, the targeted swimlanes are now correctly highlighted. The problem was introduced during the mxGraph migration, the parent variable scope change during the migration and the parent variable used to validate if the target was valid didn't refer to a Cell in maxGraph but to Window.parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target was not detected as a valid target so, the targeted swimlane was never highlighted while panning the cell over the potential target.
The problem was visible in the Swimlanes and Folding stories, the targeted swimlanes are now correctly highlighted.
The problem was introduced during the mxGraph migration, the parent variable scope change during the migration and the parent variable used to validate if the target was valid didn't refer to a Cell in maxGraph but to Window.parent.
Notes
The issue in the Folding story was visible in #385
An alternate fix was proposed in #88, see 8546ca9
Fix in the Swimlanes story