refactor: GraphDataModel.isLayer signature accepts null Cell - #389
Merged
tbouffard merged 1 commit intoApr 11, 2024
Merged
Conversation
This complements the fix that manages `null` Cell in the implementation.
tbouffard
marked this pull request as ready for review
April 11, 2024 13:28
tbouffard
deleted the
refactor/graphdatamodel_islayer_add_null_in_signature
branch
April 11, 2024 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements the fix that manages
nullCell in the implementation.Notes
Complements #365
This has been suggested in #88, see https://github.com/maxGraph/maxGraph/pull/88/files/d44b8819a75e22e73638b16c17956281d5fd52b4#diff-631ee06893c04c0fd73eb2248abff6724ddbe1c1629011af79d40e4570e693d8