refactor: set the default perimeter using a key rather than a function - #318
Merged
Merged
Conversation
This reduces the code coupling and this will also improve the tree-shaking in the future for people who don't want to rely on this perimeter implementation. Perimeter was the only configuration using an actual implementation, so this makes things more consistent.
tbouffard
marked this pull request as ready for review
February 8, 2024 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the default vertex style configuration, declare the perimeter using the key stored in the
StyleRegistryinstead of the actual perimeter function.This reduces code coupling and will also improve tree-shaking in the future for people who don't want to rely on this perimeter implementation.
The "perimeter" configuration was the only one to use an actual implementation, which makes things more consistent.
Notes
Tested with the existing stories and the new story introduced in #317