fix: CellOverlay constructor use all parameters to set properties - #159
Merged
tbouffard merged 2 commits intoDec 16, 2022
Merged
Conversation
The `align` and `verticalAlign` values passed to the constructor weren't set, so the overlay position was always set to the default one. The `align` and `verticalAlign` properties are now using the AlignValue and VAlignValue types respectively instead of defining inline types. This improves the consistent in the whole code. To demonstrate the fix, the Overlays story now set 'align' and 'verticalAlign' randomly.
cd-yang
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
alignandverticalAlignvalues passed to the constructor weren't set, so the overlay position was always set to the default one.The
alignandverticalAlignproperties are now using the AlignValue and VAlignValue types respectively instead ofdefining inline types. This improves the consistent in the whole code.
To demonstrate the fix, the Overlays story now set 'align' and 'verticalAlign' randomly.
Screenshots
See the fix in action with the Overlays story that set the overlay position randomly.
Before, the overlay position was always bottom right.
With the fix, it actually changes.
Other info
As in #152, introduce
jestto test the fix and the whole implementation of the changed method. Types check support is provided byts-jest. As maxGraph uses a lot of browser objects, also setupjest-jsdom-environment.This is a starting point. I created a discussion about a test strategy and choosing the test framework: #153.
In the short term, I would like to see this PR merged as is to move forward (see discussion for details).