chore: remove commented clearSelection in CellEditorHandler - #1075
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe PR removes a duplicate clearSelection() method from CellEditorHandler and relies on the imported clearSelection utility from domUtils; stopEditing is repositioned after isSelectText. ChangesRemove duplicate selection clearing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
redfish4ktc
force-pushed
the
chore/remove_commented_code
branch
from
May 22, 2026 15:50
150ba68 to
b2af590
Compare
The commented clearSelection method mirrored the original mxGraph implementation but was already superseded by the clearSelection utility from domUtils, which is invoked in stopEditing. Both implementations are functionally equivalent, so the dead code can be removed. This is the same mxGraph migration leftover pattern previously addressed in efb5b4b, where a stray /** left by the initial refactor silently commented out the GraphHierarchyNode.isAncestor method.
redfish4ktc
force-pushed
the
chore/remove_commented_code
branch
from
May 22, 2026 15:53
b2af590 to
8bff8bb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clearSelectionmethod inCellEditorHandler(packages/core/src/view/plugin/CellEditorHandler.ts).mxCellEditor.clearSelection, butstopEditingalready invokes the equivalentclearSelectionutility fromdomUtils.ts. The two implementations only differ in the order they proberemoveAllRangesvsempty, which is not observable in modern browsers./**left by the initial refactor silently commented out theGraphHierarchyNode.isAncestormethod.Test plan
npm run lintpasses for the changed filestopEditingalready calls the importedclearSelectionutilitySummary by CodeRabbit