fix: parse HTML instead of XML in SvgCanvas2D.convertHtml - #1012

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

packages/core/__tests__/view/canvas/SvgCanvas2D.test.ts (1)

17-22: Import extension issue from previous review is now resolved.

The barrel import from '../../../src' correctly omits the .js extension, in line with the moduleNameMapper convention for test files.

packages/core/__tests__/view/canvas/SvgCanvas2D.test.ts (1)

41-44: Global .trim() slightly weakens the "plain text unchanged" assertion.

.trim() on every case means the 'plain text unchanged if not valid HTML' test would still pass even if convertHtml returned ' plain text ', making the test name misleading. It's only strictly needed for the whitespace case (Line 40).

Consider scoping the trim to only the cases that require it, or splitting the whitespace case into its own test block:

♻️ Proposed refinement

-  ])('%s', (_description, input, expected) => {
-    const canvas = createSvgCanvas2D();
-    expect(canvas.convertHtml(input).trim()).toBe(expected);
-  });
+  ])('%s', (_description, input, expected) => {
+    const canvas = createSvgCanvas2D();
+    expect(canvas.convertHtml(input)).toBe(expected);
+  });

And update the whitespace test case's expected value to account for leading/trailing whitespace from the parsed result (or keep the trim only in a dedicated test):

test('HTML with whitespace trims surrounding whitespace', () => {
  const canvas = createSvgCanvas2D();
  expect(canvas.convertHtml('   <div> spaced </div>   ').trim()).toBe('<div> spaced </div>');
});

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro