Addresses #8045 (set_yscale("log") inconsistent with semilogy())#8056
Addresses #8045 (set_yscale("log") inconsistent with semilogy())#8056jcalbert wants to merge 1 commit intomatplotlib:masterfrom
Conversation
clipping behavior as plt.semilogy(), plt.semilogx() plt.loglog() when handing non-positive data.
| @@ -2943,7 +2943,7 @@ def set_xscale(self, value, **kwargs): | |||
| # If the scale is being set to log, clip nonposx to prevent headaches | |||
There was a problem hiding this comment.
update the comment too? (below as well)
|
I spent a while hunting this down until I realized that, in fact, the before- and after- images should look different. For the moment I can't figure out how the old test conspired to make One possibility is the way MPL chooses the axis bounds. Shown below are four plots, the Cartesian product of ( compare the above output from mpl 1.5.1 to this from mpl 2.0.0: is is evident that mpl1 has chosen x-axis limits that mostly obscure the difference between It seems that whichever behavior we want, we will need a test that more explicitly checks the distinction. |
|
Most old tests still use the classic style, where the plots use "round" numbers as limits, so that's probably why they still passed. Updating the test images should make this good. |
|
This ended up being superseeded by #8836, thanks for the PR though! |
See: #8045 "setting yscale to log, after drawing a plot with values equal to zero, results in incorrect handling of zero values "