Fixed GraphicsContextBase linestyle getter#7730
Conversation
|
For reference, this has been like this since e34a333 and has no previous history. We also do not appear to ever use it internally. All of our backends use This needs an API changes note (there may be third-party backends working around this), but given that the current API is obviously problematic (and no one has complained) I do not think it needs a deprecation cycle. |
|
So I assume it is safe to fix this without deprecation (or even to remove the property). |
|
If we're going to break backcompat, let's just remove the property? |
|
power cycled to run CI with fixes from master branch to other tests. |
Current coverage is 62.52% (diff: 100%)@@ master #7730 diff @@
==========================================
Files 174 174
Lines 56028 56703 +675
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34805 35453 +648
- Misses 21223 21250 +27
Partials 0 0
|
|
LGTM 👍 |
Closes #3354