Apply new default colours in more places#5995
Conversation
|
Not sure why CI failed the first time, but I re-started it and it seems to be good now. |
|
I this addresses the same issue as #5674 I believe. |
|
Hmm, you're probably right, except that one is a bit more general and adds an additional feature for users, while this one is just straight hard-coding. Probably depends on what the consensus is for that new feature. |
| # line props | ||
| 'lines.linewidth': [2.5, validate_float], # line width in points | ||
| 'lines.linestyle': ['-', six.text_type], # solid line | ||
| 'lines.color': ['b', validate_color], # blue |
|
I think this can be re-worked to use the new |
|
Quite likely; I think a bunch of it is already implemented, too. For the stem plots, the baseline was originally red. That's C2 for the classic colour cycle, but C3 for the new one (C2 is green). Should I go with C2 everywhere, or just special case classic style with C3 everywhere? |
|
I think the red of stem plots should be treated specially, as in a separate On Sun, May 1, 2016 at 11:28 PM, Elliott Sales de Andrade <
|
|
Yes, there is a separate argument for the |
41993b2 to
301bf04
Compare
301bf04 to
76756ac
Compare
|
Rebased to fix latest v2.x build issues. |
| linemarker = 'None' | ||
| linestyle = '-' | ||
| else: | ||
| linestyle, linemarker, linecolor = \ |
There was a problem hiding this comment.
is the \ really needed?
(linestyle, linemarker,
linecolor) = _process_plot_format(linefmt)is another way to break this up
|
This is down to just All of my comments on this are non-critical. |
Some hardcoded defaults in
scatter,pie, andstemplot(though now that I think about it, maybe that last one should be inrcParams, too.)Also, set default colour for lines and boxplots to the new blue (and red, in some cases).
Fixes #5990.