Skip to content

Fix #5519: Patch now support the 'None' linestyle#5696

Closed
Rezangyal wants to merge 1 commit intomatplotlib:v2.0.xfrom
Rezangyal:none_linestyle_fix3
Closed

Fix #5519: Patch now support the 'None' linestyle#5696
Rezangyal wants to merge 1 commit intomatplotlib:v2.0.xfrom
Rezangyal:none_linestyle_fix3

Conversation

@Rezangyal
Copy link
Copy Markdown
Contributor

@Rezangyal Rezangyal commented Dec 19, 2015

If patch.linestyle is 'none', 'None', ' ', '' or None then no edge rendered (as in Line2D).
This fix #5519.

@Rezangyal
Patch now support the "None" linestyle
c7c7005 
If patch.linestyle  is "none", "None", " ", "" or None then no edge
rendered (as in Line2D).
@Rezangyal Rezangyal mentioned this pull request Dec 19, 2015
Closed
tacaswell
tacaswell reviewed Dec 19, 2015
View reviewed changes
Comment thread lib/matplotlib/patches.py
Copy link
Copy Markdown
Member

@tacaswell tacaswell Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include None in this check. We reserve None to mean 'do the default thing' not 'do nothing'.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Dec 19, 2015

Can you also add a test (see http://matplotlib.org/devel/testing.html#writing-an-image-comparison-test + look at other tests in the test suite for how to do this)?

@Rezangyal
Copy link
Copy Markdown
Contributor Author

Rezangyal commented Dec 19, 2015

ok, tomorrow.

@tacaswell tacaswell closed this Dec 19, 2015
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Dec 19, 2015

@Rezangyal Can you please re-open this against the v2.x branch? There was a mistake on our side that needed to be fixed which required deleting the v2.0.x branch.

@Rezangyal
Copy link
Copy Markdown
Contributor Author

Rezangyal commented Dec 20, 2015

I create a new branch (https://github.com/Rezangyal/matplotlib/tree/fix_linestyle_none),
but the test is not working to me.
When I set local_freetype = True in setup.cfg I receive an error message:

running build_ext
Building freetype-2.6.1.tar.gz
'"CFLAGS=\"' is not recognized as an internal or external command, operable program or batch file.
Traceback (most recent call last):
  File "setup.py", line 290, in <module>
    **extra_args
...
  File "setup.py", line 144, in run
    package.do_custom_build()
  File "x:\git\matplotlib\setupext.py", line 1000, in do_custom_build
    '--with-png=no --with-harfbuzz=no'], shell=True, cwd=src_path)
  File "x:\Python27\lib\subprocess.py", line 511, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['CFLAGS=" -fPIC" ./configure --with-zlib=no --with-bzip2=no --with-png=no --with-harfbuzz=no']' returned non-zero exit status 1

(python27 32bit, windows8.1)
maybe the 'set' is missing from command line

@mdboom
Copy link
Copy Markdown
Member

mdboom commented Dec 22, 2015

When I set local_freetype = True in setup.cfg I receive an error message:

Sorry, I think that feature isn't yet working on Windows. @JanSchulz: can you confirm that, or should that be working?

@jankatins
Copy link
Copy Markdown
Contributor

jankatins commented Dec 22, 2015

I haven't tried the internal freetype yet. There is a todo in #5629

@jankatins jankatins mentioned this pull request Dec 22, 2015
Merged
12 tasks
@phobson phobson mentioned this pull request Jan 24, 2017
Closed
@QuLogic QuLogic mentioned this pull request Oct 2, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rezangyal @tacaswell @mdboom @jankatins