Only use asynchronous redraw methods when handling GUI events in Qt5Agg (fix #4604)#4612
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom Jul 22, 2015
pwuertz:fix_4604
Merged
Only use asynchronous redraw methods when handling GUI events in Qt5Agg (fix #4604)#4612tacaswell merged 2 commits intomatplotlib:masterfrom pwuertz:fix_4604
tacaswell merged 2 commits intomatplotlib:masterfrom
pwuertz:fix_4604
Conversation
Contributor
Author
|
For testing purposes I removed the update/redraw() switch for windows that was introduced because windows users reported a insufficient amount of actual redraws on Qt4Agg/Win. It could be possible that this was actually the same problem back then if Qt4/Win emitted events more frequently than Qt4/X11 or Qt4/OSX. Could a Windows user confirm that Qt5Agg is working fine with this PR? |
Member
|
The |
Member
|
I can confirm both the bug and that this fixes it. Both the qt4 and qt5 backends work fine wrt pan/zoom updates for me with this. I am going to merge this now and make a note with the RC that this will need testing on mac + windows. |
tacaswell
added a commit
that referenced
this pull request
Jul 22, 2015
FIX: Only use asynchronous redraw methods when handling GUI events in Qt5Agg Fix #4604
This was referenced Aug 11, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling events like mouse movements during zoom/pan, the Qt5 backend forced a redraw of the Agg canvas for every event. Redraw operations should be done only when the GUI is ready to display another frame, else the rendering performance is going to be crushed on systems where Qt emits events more frequently.