Skip to content

Raise missing ValueError in transform_angles#4458

Merged
WeatherGod merged 1 commit intomatplotlib:masterfrom
has2k1:fix-transform-angles-unraised-error
May 23, 2015
Merged

Raise missing ValueError in transform_angles#4458
WeatherGod merged 1 commit intomatplotlib:masterfrom
has2k1:fix-transform-angles-unraised-error

Conversation

@has2k1
Copy link
Copy Markdown
Contributor

@has2k1 has2k1 commented May 23, 2015

  • Includes a small PEP8 change
  • Added tests to cover the Transform.transform_angles method

WeatherGod
WeatherGod reviewed May 23, 2015
View reviewed changes
Comment thread lib/matplotlib/tests/test_transforms.py Outdated
Copy link
Copy Markdown
Member

@WeatherGod WeatherGod May 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future coders, could you add a comment explaining the error you are triggering?

@WeatherGod WeatherGod mentioned this pull request May 23, 2015
Merged
@WeatherGod
Copy link
Copy Markdown
Member

WeatherGod commented May 23, 2015

I restarted the failing test, now it is saying that assert_raises() takes three arguments... did nose bork a release or something?

@jenshnielsen
Copy link
Copy Markdown
Member

jenshnielsen commented May 23, 2015

@WeatherGod Assert_raises can't be used as a context manager in python 2.6. I would suggest just skipping this test on python 2.6 as done in https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_rcparams.py#L127

@WeatherGod
Copy link
Copy Markdown
Member

WeatherGod commented May 23, 2015

Didn't know that. Good to know!

On Sat, May 23, 2015 at 10:56 AM, Jens Hedegaard Nielsen <
notifications@github.com> wrote:

@WeatherGod https://github.com/WeatherGod Assert_raises can't be used
as a context manager in python 2.6. I would suggest just skipping this test
on python 2.6 as done in
https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_rcparams.py#L127

—
Reply to this email directly or view it on GitHub
#4458 (comment)
.

@has2k1
Raise missing ValueError in transform_angles
06d0892 
- Includes a small PEP8 change
- Added tests to cover the `Transform.transform_angles` method
@has2k1 has2k1 force-pushed the fix-transform-angles-unraised-error branch from d3254ec to 06d0892 Compare May 23, 2015 18:44
@has2k1
Copy link
Copy Markdown
Contributor Author

has2k1 commented May 23, 2015

Well, that worked this time around.

Commented the tests.

WeatherGod added a commit that referenced this pull request May 23, 2015
@WeatherGod
Merge pull request #4458 from has2k1/fix-transform-angles-unraised-error
e1a52a9 
Raise missing ValueError in transform_angles
@WeatherGod WeatherGod merged commit e1a52a9 into matplotlib:master May 23, 2015
@WeatherGod
Copy link
Copy Markdown
Member

WeatherGod commented May 23, 2015

This does not need backporting. The exception was only missing in master.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented May 24, 2015

@has2k1 Thanks! I should have caught that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@has2k1 @WeatherGod @jenshnielsen @tacaswell