How does this compare to #4258?

Our implementation is simpler, we don't handle the composition of different styles. We simply cycle through the given styles and combine them when you call next(). However, a seperate function could be created to help the users create cycles similar to the one made by tacaswell.
We also integrated our some of our input validation with rcParams.

I think that #4258 is simpler and more powerful (but I am biased 😉 ).

Left some comments about technical issues, but I am not a huge fan of this design, it seems too brittle.

Should probably take a look at #4258

On Sun, Apr 5, 2015 at 7:25 PM, jasonliw93 notifications@github.com wrote:

Implemented a style cycle feature for Issue #2841
#2841
We incorporated the requested feature for a linestyle cycle that behaves
like the existing color cycle, however we created a new class called Cycle
to add the ability to cycle through less common line styles as well.
Currently, it is only used and owned by axes for plotting lines, but this

could be extensible to other plots in the future as well.

You can view, comment on, or merge this pull request online at:

#4314
Commit Summary

• Feature implementation for Issue 2841
• Merge branch 'master' of https://github.com/matplotlib/matplotlib
  into Issue2841
• Added automated tests for cycle issue There is no set_linestyle_cycle in the matplotlib axes API #2841
• Added additional validation, test cases, and fixed minor bugs

File Changes

• M lib/matplotlib/init.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-0 (1)
• M lib/matplotlib/axes/_axes.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-1 (4)
• M lib/matplotlib/axes/_base.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-2 (58)
• A lib/matplotlib/cycle.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-3
  (140)
• M lib/matplotlib/rcsetup.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-4 (31)
• M lib/matplotlib/stackplot.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-5 (4)
• M lib/matplotlib/streamplot.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-6 (2)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_all_cycle.pdf
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-7 (0)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_all_cycle.png
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-8 (0)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_all_cycle.svg
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-9
  (660)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_one_cycle.pdf
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-10 (0)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_one_cycle.png
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-11 (0)
• A
  lib/matplotlib/tests/baseline_images/test_cycle/clear_one_cycle.svg
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-12
  (660)
• A lib/matplotlib/tests/baseline_images/test_cycle/set_cycles.pdf
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-13 (0)
• A lib/matplotlib/tests/baseline_images/test_cycle/set_cycles.png
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-14 (0)
• A lib/matplotlib/tests/baseline_images/test_cycle/set_cycles.svg
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-15
  (902)
• A lib/matplotlib/tests/test_cycle.py
  https://github.com/matplotlib/matplotlib/pull/4314/files#diff-16
  (52)

Patch Links:

• https://github.com/matplotlib/matplotlib/pull/4314.patch
• https://github.com/matplotlib/matplotlib/pull/4314.diff

—
Reply to this email directly or view it on GitHub
#4314.

And, I just noticed that the PR got its title changed, so the subsequent comments didn't show up in the same thread in gmail... ignore me.

Thank you for all the comments tacaswell, this was a good learning experience nonetheless and feel free to take any ideas from our implementation if this doesn't get merged.

One major design design difference is that your Cycler is the iterator, where as mine is iterable. It is a subtle difference and I am not completely sure which way is the right way to go. I think that it would be very difficult to do composition using your method (as how do you compose cycles at different points along their trajectories?).

On the other hand, I do appreciate the minimal amount of API breakage that this has. On the other other hand, it may be an API that needs to be broken to move forward.

Closing in favor of a solution built on #4258

@jasonliw93 @lichri12 Even though this didn't get merged thank you for you work!

Closing PRs with out merging is my least favorite part of maintaining mpl 😞 .