add new feature to create scientific table (#4044 )#4269
Closed
KaiSong2014 wants to merge 1 commit intomatplotlib:masterfrom
Closed
add new feature to create scientific table (#4044 )#4269KaiSong2014 wants to merge 1 commit intomatplotlib:masterfrom
KaiSong2014 wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Member
|
There are a great many changes in here that should not be (all of the re-additions of I suggest you create a new branch (not 'master') and put your changes on that branch an open a new PR against matplotlib master from your feature branch. I am going to close this PR due to git-related issues (being from your master and the extraneous code changes). Please see http://matplotlib.org/devel/gitwash/development_workflow.html. |
Member
There was a problem hiding this comment.
This is an API break, please restore this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we used factory design pattern to implement the feature #4044
Here is our user example:
import matplotlib.pyplot as plt
import matplotlib.table as mtable
fig = plt.figure()
ax = fig.add_subplot(111)
l1 = [1, 2]
l2 = [3, 4]
t = ax.scitable(
colWidths=[0.4, 0.4],
cellText = [l1, l2],
loc="center",
colLoc="center",
rowLoc="center")
plt.show()