Skip to content

[WIP] Fix annotation get window extent#4023

Closed
itziakos wants to merge 8 commits intomatplotlib:masterfrom
itziakos:fix-annotation-get-window-extent
Closed

[WIP] Fix annotation get window extent#4023
itziakos wants to merge 8 commits intomatplotlib:masterfrom
itziakos:fix-annotation-get-window-extent

Conversation

@itziakos
Copy link
Copy Markdown
Contributor

@itziakos itziakos commented Jan 21, 2015

This PR reworks Annotation to provide a get_window_extent method that will return as bounding box the union of the contained text and arrow.

Pending:

  • more tests
  • cleanup

@itziakos itziakos mentioned this pull request Jan 21, 2015
Closed
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 21, 2015

Great!

This looks like it will need a re-base to current master already.

@itziakos
Copy link
Copy Markdown
Contributor Author

itziakos commented Jan 21, 2015

I am on it

@itziakos
Merge branch 'master' into fix-annotation-get-window-extent
a901704 
Conflicts:
	lib/matplotlib/tests/test_text.py
@itziakos
Copy link
Copy Markdown
Contributor Author

itziakos commented Jan 21, 2015

conflict resolved, please note that I still need to fix and add a couple of tests

tacaswell
tacaswell reviewed Jan 21, 2015
View reviewed changes
Comment thread lib/matplotlib/tests/test_text.py
Copy link
Copy Markdown
Member

@tacaswell tacaswell Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easier to add the @cleanup decorator use pyplot to make your figure/axes objects.

Copy link
Copy Markdown
Member

@tacaswell tacaswell Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I now see why you are doing it this way.

@tacaswell tacaswell added this to the v1.4.3 milestone Jan 26, 2015
@tacaswell tacaswell mentioned this pull request Jan 27, 2015
Closed
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 31, 2015
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 31, 2015

I have cherry-picked these over to be based on the 1.4.x branch. I should have a version of this merged in the near future.

tacaswell added a commit that referenced this pull request Jan 31, 2015
@tacaswell
Merge Merge pull request #4023 from itziakos/fix-annotation-get-windo…
26c7d65 
…w-extent

BUG : annotation objects did not report their window extent properl
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 31, 2015

Merged in to v1.4.x as 26c7d65

@tacaswell tacaswell closed this Jan 31, 2015
@itziakos
Copy link
Copy Markdown
Contributor Author

itziakos commented Feb 1, 2015

Thanks @tacaswell.

Sorry for the delay. I will make a separate PR for the additional tests.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Feb 1, 2015

@itziakos Thanks for your work.

Sorry if you feel like I stepped on your toes, I wanted to get this in and this was the fastest path to get there.

@itziakos
Copy link
Copy Markdown
Contributor Author

itziakos commented Feb 2, 2015

Sorry if you feel like I stepped on your toes, I wanted to get this in and this was the fastest path to get there.

There was no offense taken, It is me who should apologize for the delay.

@jenshnielsen jenshnielsen mentioned this pull request Feb 21, 2015
Closed
@cimarronm cimarronm mentioned this pull request Feb 22, 2015
Closed
@tacaswell tacaswell mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v1.4.3

Development

Successfully merging this pull request may close these issues.

2 participants

@itziakos @tacaswell