-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[MNT]: Implement Scale.val_in_range and refactor _point_in_data_domain
#31306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+121
−2
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c3df005
scale: add `ScaleBase.val_in_range` for domain validation
null-dreams f91d2b4
typing: add `ScaleBase.val_in_range` to `scale.pyi`
null-dreams 926c259
axis: add `Axis.val_in_range` to delgate the domain check
null-dreams e3dc7b7
typing: add `Axis.val_in_range` to `axis.pyi`
null-dreams 6feeec1
axes: modify `_point_in_data_domain` to use the new `Axis.val_in_range`
null-dreams 631a52f
scale: refactor `val_in_range` to accept scalar values and return a s…
null-dreams d62a69f
typing: refactor `Scale.val_in_range` to reflect the type changes
null-dreams 59bd52b
tests: add test cases for `val_in_range` for different scales
null-dreams 6d03949
refactor: remove 'val_in_range' from axis.py and the corressponding p…
null-dreams b78b003
refactor: add finite bound check for base class and implemented classes
null-dreams 3de6b1f
tests: edited test cases to fit the new requirements
null-dreams c35268f
refactor: compact function body in LogScale
null-dreams 6b820a8
refactor: made changes as suggested by reviewer
null-dreams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring should always descripe the concept, not just the imlementation. A docstring
has zero information conent.
Instead do:
The first sentence should be in all
val_in_rangedocs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually pretty enlightening. Kind of changed the way I thought about docstrings.
I'm making the needed changes. Thank you very much for the suggestion.