Matplotlib Device Scaling on Windows#30599
Open
melwyncarlo wants to merge 2 commits intomatplotlib:mainfrom
Open
Matplotlib Device Scaling on Windows#30599melwyncarlo wants to merge 2 commits intomatplotlib:mainfrom
melwyncarlo wants to merge 2 commits intomatplotlib:mainfrom
Conversation
tacaswell
reviewed
Sep 25, 2025
| self.window.protocol("WM_DELETE_WINDOW", destroy) | ||
| self.window.deiconify() | ||
| self.canvas._tkcanvas.focus_set() | ||
| if self._window_dpi.get() != 96: |
Member
|
How does this intersect with the discussion in #21875 ? |
tacaswell
reviewed
Sep 25, 2025
| (GetDpiForWindow_t)GetProcAddress(user32, "GetDpiForWindow"); | ||
| if (GetDpiForWindowPtr == NULL) { | ||
| FreeLibrary(user32); | ||
| return py::cast(false); |
Member
There was a problem hiding this comment.
Is completely returning here correct? Is there a case where we may not be able to get the methods for managing the dpi but still need to run the setWindowSubclass method?
anntzer
reviewed
Sep 29, 2025
| // window_dpi variable stored on interp. | ||
| typedef UINT (WINAPI *GetDpiForWindow_t)(HWND); | ||
| GetDpiForWindow_t GetDpiForWindowPtr = | ||
| (GetDpiForWindow_t)GetProcAddress(user32, "GetDpiForWindow"); |
Contributor
There was a problem hiding this comment.
Please use the shorter style for casting as in #30615.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR closes #26733.
Basically, the change in DPI is signaled when resizing or changing the device scale, and not when the canvas is launched/loaded, hence the issue.
This video demonstrates the problem and the fix.