Skip to content

FUTURE BUG: reconsider how we deep-copy path objects #29157 #29161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saikarna913 wants to merge 2 commits into from
Closed

FUTURE BUG: reconsider how we deep-copy path objects #29157 #29161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f6618
Update path.py
saikarna913 Nov 20, 2024
5904179
Merge branch 'matplotlib:main' into Feature2
saikarna913 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/matplotlib/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,21 @@ def __deepcopy__(self, memo=None):
readonly, even if the source `Path` is.
"""
# Deepcopying arrays (vertices, codes) strips the writeable=False flag.
p = copy.deepcopy(super(), memo)
p._readonly = False
return p
cls = self.__class__
new_instance = cls.__new__(cls)

# Add the new instance to the memo dictionary to handle circular references
if memo is None:
memo = {}
memo[id(self)] = new_instance

# Deepcopy the attributes explicitly
new_instance.vertices = copy.deepcopy(self.vertices, memo)
new_instance.codes = copy.deepcopy(self.codes, memo)
new_instance._readonly = False

return new_instance


deepcopy = __deepcopy__

Expand Down