DOC: Fix missing cross-reference checks for sphinx-tags#28820
Merged
jklymak merged 2 commits intomatplotlib:mainfrom Sep 15, 2024
Merged
DOC: Fix missing cross-reference checks for sphinx-tags#28820jklymak merged 2 commits intomatplotlib:mainfrom
jklymak merged 2 commits intomatplotlib:mainfrom
Conversation
In cda4372, I "simplified" from `node['refdomain']` to the existing `domain` argument. With `sphinx-tags`, the `warn-missing-reference` event occurs for a `None` domain, and we crash trying to access `domain.name`. But `node['refdomain']` is still an empty string, so revert back to that.
5 tasks
story645
approved these changes
Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In cda4372, I "simplified" from
node['refdomain']to the existingdomainargument. Withsphinx-tags, thewarn-missing-referenceevent occurs for aNonedomain, and we crash trying to accessdomain.name. Butnode['refdomain']is still an empty string, so revert back to that.Noticed this as part of #27302.
PR checklist