Correct numpy dtype comparisons in image_resample#28458
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jun 25, 2024
Merged
Correct numpy dtype comparisons in image_resample#28458QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
approved these changes
Jun 25, 2024
QuLogic
approved these changes
Jun 25, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 25, 2024
QuLogic
added a commit
that referenced
this pull request
Jun 26, 2024
…458-on-v3.9.x Backport PR #28458 on branch v3.9.x (Correct numpy dtype comparisons in image_resample)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Correct numpy dtype comparisons in
image_resampleC++ code.Previously we were using
dtype1.is(dtype2)(the pybind11 C++ equivalent ofdtype1 is dtype2in Python) whereas we should have been usingdtype1.equal(dtype2)(the pybind11 C++ equivalent ofdtype1 == dtype2in Python).PR checklist