Remove backend 3.7-deprecated API #26962#27225
Closed
Vishnu9535 wants to merge 1 commit intomatplotlib:mainfrom
Closed
Remove backend 3.7-deprecated API #26962#27225Vishnu9535 wants to merge 1 commit intomatplotlib:mainfrom
Vishnu9535 wants to merge 1 commit intomatplotlib:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Lambxx
reviewed
Nov 2, 2023
Member
|
It looks like all these deprecated features have already been removed, so I'll close this. Thanks for opening though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Removal of old and unused API that were marked as deprecated in 3.7 of Matplotlib
(issue #26865)
changes made :
Removed PsBackendHelper class and ServerThread class which were deprecated in 3.7 version of Matplotlib
Also removed PyBufferRegion_to_string and PyBufferRegion_to_string_argb methods from c++ files as they were also deprecated in 3.7 version of Matplotlib.
PR checklist