Skip to content

Look for user-specified styles in ~/.config/matplotlib/stylelib#2720

Merged
mdboom merged 4 commits intomatplotlib:masterfrom
alimuldal:styles_XDG_compliance
Jan 13, 2014
Merged

Look for user-specified styles in ~/.config/matplotlib/stylelib#2720
mdboom merged 4 commits intomatplotlib:masterfrom
alimuldal:styles_XDG_compliance

Conversation

@alimuldal
Copy link
Copy Markdown
Contributor

@alimuldal alimuldal commented Jan 11, 2014

Hi all,
I just noticed that the styles module currently only looks for user-specified styles in ~/.matplotlib/stylelib. I think it ought to also look in ~/.config/matplotlib/stylelib/ for consistency with ~/.config/matplotlib/matplotlibrc and in order to comply with the latest XDG standard (c.f. #454).

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 13, 2014

Can you please clean up the PEP8 violations? It looks like you left some trailing white space on one of the lines.

This changes looks reasonable to me, but I suspect that this should have a more correct handling of paths (does '~' work on windows?) like the way rcparams handles the same problem.

I see no reason not to merge this (once pep8 is fixed), but it is a stop-gap.

@alimuldal
Copy link
Copy Markdown
Contributor Author

alimuldal commented Jan 13, 2014

'~' is handled by os.path.expanduser - on Windows this will use the HOME and USERPROFILE environment variables if set, or else it will use HOMEPATH and HOMEDRIVE. I don't see any reason why this wouldn't work, but I don't have a Windows machine handy to test it at the moment.

pelson
pelson reviewed Jan 13, 2014
View reviewed changes
Comment thread lib/matplotlib/style/core.py Outdated
Copy link
Copy Markdown
Member

@pelson pelson Jan 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better if it just used matplotlib._get_configdir() and then it can be configured in a consistent way. @tonysyu, did you have a motivation for not using that function in the first place, or was it just a case of it being well hidden?

mdboom added a commit that referenced this pull request Jan 13, 2014
@mdboom
Merge pull request #2720 from alimuldal/styles_XDG_compliance
0722bc3 
Look for user-specified styles in ~/.config/matplotlib/stylelib
@mdboom mdboom merged commit 0722bc3 into matplotlib:master Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alimuldal @tacaswell @pelson @mdboom