Skip to content

Deprecate mixing positional and keyword args for legend(handles, labels)#27175

Merged
dstansby merged 1 commit intomatplotlib:mainfrom
anntzer:lpk
Oct 26, 2023
Merged

Deprecate mixing positional and keyword args for legend(handles, labels)#27175
dstansby merged 1 commit intomatplotlib:mainfrom
anntzer:lpk

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Oct 23, 2023

This was previously already a warning and also broken.

Closes #26841.

PR summary

PR checklist

Comment thread doc/api/next_api_changes/deprecations/27175-AL.rst Outdated
@dstansby dstansby added this to the v3.9.0 milestone Oct 25, 2023
@dstansby
Copy link
Copy Markdown
Member

I presume the failing test is a flaky one (it's an interactive test), but haven't been around recenly enough to know for sure!

This was previously already a warning and also broken.
Copy link
Copy Markdown
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@dstansby dstansby merged commit 378d115 into matplotlib:main Oct 26, 2023
@anntzer anntzer deleted the lpk branch October 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Global legend weird behaviors

3 participants