Closed
Conversation
64 tasks
ksunden
approved these changes
Oct 24, 2023
Member
ksunden
left a comment
There was a problem hiding this comment.
Could be simplified a bit, but it is largely fine:
- Use
np.arangeinstead ofnp.array(range(...)) - Could even use
np.arangefor the dates e.g.:
np.arange(start_date, start_date+datetime.timedelta(weeks=1), datetime.timedelta(days=1))Does work
Also the last axes using the data arg I don't think really needs to be tested here, its not wrong, but it is testing a broader functionality that is largely orthogonal.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Smoke test for Axes.step using datetime data in lib/matplotlib/tests/test_datetime.py. This PR addresses one of the tasks listed in #26864
The image displays the plot of the test case:
PR checklist