Removed the deprecated code from offsetbox.py#26910
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
ksunden
left a comment
There was a problem hiding this comment.
Just a bit of an adjustment to the release note,
These methods have alternatives that should be mentioned here, though you can largely copy/paste from the deprecation notice, just reflecting that they are removed rather than deprecated
| ``bbox_artist`` | ||
| ~~~~~~~~~~~~~~~~ | ||
| ... of `matplotlib.offsetbox` is removed without replacements. | ||
| ``get_extent_offsets`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| ... of `matplotlib.offsetbox` is removed without replacements. | ||
| ``get_extent`` | ||
| ~~~~~~~~~~~~~~~ | ||
| ... of `matplotlib.offsetbox` is removed without replacements. |
There was a problem hiding this comment.
All of these have alternatives that are mentioned in the deprecation decorator, so they are not removed "without replacements"
See the deprecation note, which can be modified to reflect the "removed" rather than "deprecated":
matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst
Lines 211 to 215 in 6028039
matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst
Lines 191 to 201 in 6028039
There was a problem hiding this comment.
@ksunden changed the rst file to reflect the requested changes. Please let me know if any more modifications are needed.
Co-authored-by: Kyle Sunden <git@ksunden.space>
rcomer
left a comment
There was a problem hiding this comment.
Just a couple of very minor things!
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
rcomer
left a comment
There was a problem hiding this comment.
Thanks @jpgianfaldoni! This can be merged once the checks pass again.
|
Thanks @jpgianfaldoni! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
This PR removes the deprecated code during the version 3.7 from lib/matplotlib/offsetbox.py which is a sub issue in the parent issues here: #26865
-->
PR checklist