allsegs and allkinds return individual segments#26908
Merged
greglucas merged 1 commit intomatplotlib:mainfrom Oct 10, 2023
Merged
allsegs and allkinds return individual segments#26908greglucas merged 1 commit intomatplotlib:mainfrom
allsegs and allkinds return individual segments#26908greglucas merged 1 commit intomatplotlib:mainfrom
Conversation
jklymak
approved these changes
Sep 25, 2023
Member
jklymak
left a comment
There was a problem hiding this comment.
Thanks! I was dreading digging into the path API to figure this out....
Member
Author
|
I had previous digging around in there when I was fixing Cartopy! |
Member
Author
|
Have now opened #26913 for the deprecation question, so linked the original issue here. |
greglucas
approved these changes
Oct 10, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 10, 2023
…ual segments
oscargus
added a commit
that referenced
this pull request
Oct 10, 2023
…908-on-v3.8.x Backport PR #26908 on branch v3.8.x (`allsegs` and `allkinds` return individual segments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #26863. I think this reinstates the pre-3.8 behaviour. Adapted @jklymak's example from #26863 (comment) into the new test.
PR checklist