ENH: clip_path keyword for contour and contourf#26278
Merged
greglucas merged 1 commit intomatplotlib:mainfrom Jul 14, 2023
Merged
ENH: clip_path keyword for contour and contourf#26278greglucas merged 1 commit intomatplotlib:mainfrom
greglucas merged 1 commit intomatplotlib:mainfrom
Conversation
844ff44 to
ea59f24
Compare
oscargus
approved these changes
Jul 9, 2023
QuLogic
reviewed
Jul 11, 2023
Member
QuLogic
left a comment
There was a problem hiding this comment.
If you do want in image test, it might be possible to use a check_figures_equal test instead of a new image.
Comment on lines
1874
to
+1878
| data : indexable object, optional | ||
| DATA_PARAMETER_PLACEHOLDER | ||
|
|
||
| clip_path : `~matplotlib.patches.Patch` or `.Path` or `.TransformedPath` | ||
| Set the clip path. See `~matplotlib.artist.Artist.set_clip_path`. | ||
|
|
||
| .. versionadded:: 3.8 | ||
|
|
Member
There was a problem hiding this comment.
I think we prefer data to be last, though I'm not sure about new arguments.
Member
Author
There was a problem hiding this comment.
greglucas
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #2369. Thanks to #25247, we now only need some very minor plumbing to expose clip_path in
contourandcontourf.I'm unsure whether this should have an image test. For now, I just went for the simplest test that fails against
main. I didn't add an example because we already have examples for both contours and clipping (the above, which is also the what's new entry, was adapted from this one and this one).PR checklist