Support make_compound_path concatenating only empty paths.#25252
Merged
jklymak merged 1 commit intomatplotlib:mainfrom Feb 20, 2023
Merged
Support make_compound_path concatenating only empty paths.#25252jklymak merged 1 commit intomatplotlib:mainfrom
jklymak merged 1 commit intomatplotlib:mainfrom
Conversation
Previously `codes[i]` would fail if codes (i.e. the concatenated path) had length zero.
greglucas
approved these changes
Feb 19, 2023
jklymak
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
codes[i]would fail if codes (i.e. the concatenated path) had length zero.Split out as preparatory work for #25247 (which introduces empty paths for contour levels that don't actually result in any level being drawn).
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst