Add deprecation for setting data with non sequence type in Line2D#25196
Merged
oscargus merged 2 commits intomatplotlib:mainfrom Feb 12, 2023
Merged
Conversation
c8a44ac to
044fbc0
Compare
jklymak
approved these changes
Feb 11, 2023
2 tasks
oscargus
approved these changes
Feb 12, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 12, 2023
…on sequence type in `Line2D`
dstansby
pushed a commit
that referenced
this pull request
Feb 12, 2023
…e type in `Line2D` (#25201) Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #22329 to add a deprecation cycle for this API change and avoid breaking dependent libraries! :)
PR Summary
The following will now raise a
MatplotlibDeprecationWarninginstead ofRuntimeError:PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst