added a note to avoid f-strings in logging#25081
Merged
jklymak merged 5 commits intomatplotlib:mainfrom Mar 6, 2023
muddi900:add/doc-note-fstrings
Merged
added a note to avoid f-strings in logging#25081jklymak merged 5 commits intomatplotlib:mainfrom muddi900:add/doc-note-fstrings
jklymak merged 5 commits intomatplotlib:mainfrom
muddi900:add/doc-note-fstrings
Conversation
Member
|
@muddi900 Would you also be willing to add an example of how it should be done to the examples? It is not just fstrings, it is any "pre-computed" formatting that is the problem. |
Contributor
Author
|
I'll ammend ot on the next day or so. |
tacaswell
reviewed
Jan 27, 2023
oscargus
reviewed
Feb 7, 2023
jklymak
reviewed
Feb 7, 2023
jklymak
reviewed
Feb 7, 2023
Member
|
Is this complete? Please mark the PR as Ready for review if so. |
jklymak
reviewed
Feb 23, 2023
jklymak
reviewed
Feb 24, 2023
Member
|
You are failing a check in |
added code blocks of examples and changed to pre-computed fixed code-block formatting More gramar and format fixes
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Jody Klymak <jklymak@gmail.com>
story645
requested changes
Feb 27, 2023
6 tasks
story645
approved these changes
Mar 1, 2023
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Member
|
Docs build has now passed and the section looks like this. |
Member
|
Thanks @muddi900 ! |
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
* added a note to avoid f-strings in logging ------ Co-authored-by: Jody Klymak <jklymak@gmail.com>
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
* added a note to avoid f-strings in logging ------ Co-authored-by: Jody Klymak <jklymak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As per #25080, a note has been added to the
contributing.rstPR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst