Swap ipython directives for code-block directives#24934
Merged
jklymak merged 1 commit intomatplotlib:mainfrom Jan 10, 2023
Merged
Swap ipython directives for code-block directives#24934jklymak merged 1 commit intomatplotlib:mainfrom
jklymak merged 1 commit intomatplotlib:mainfrom
Conversation
tacaswell
approved these changes
Jan 10, 2023
timhoffm
approved these changes
Jan 10, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 10, 2023
QuLogic
added a commit
that referenced
this pull request
Jan 11, 2023
…934-on-v3.7.x Backport PR #24934 on branch v3.7.x (Swap ipython directives for code-block directives)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I was having some trouble building docs locally due to some bad interaction between
the ipython sphinx directive and running in a virtual environment (despite ipython being installed in the environment)
Rather than spending a large amount of time figuring out how to resolve those incompatibilities, I just removed
the directive that was causing the problem and replaced it with
code-blockwhich is what we use everywhere else (that isn't a plot) anyway.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst