TST: Set explicit styles for image tests#24709
TST: Set explicit styles for image tests#24709oscargus wants to merge 1 commit intomatplotlib:mainfrom
Conversation
|
Turns out that these are not all, but all that was found in my IDE... I was surprised that it wasn't that many, but clearly I was wrong. Anyway, I expected to do this is steps, so this is one step. |
| @image_comparison(['agg_filter.png'], remove_text=True) | ||
| # # Update style when regenerating the test image | ||
| @image_comparison(['agg_filter.png'], remove_text=True, | ||
| style=("classic", "_classic_test_patch")) |
There was a problem hiding this comment.
Having this baseline + patch style combination is a bit bulky given that we write it all over the tests. I suggest to create a _classic_test style that hard-coded merges both.
There was a problem hiding this comment.
@oscargus were you going to update this? Overall I think this is a great idea...
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
|
Superseeded by #31148. |
PR Summary
Change all image test styles to explicit so that it is possible to change the default at some later stage.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst