minor pep8 fix on every file#2460
Merged
pelson merged 1 commit intomatplotlib:masterfrom Sep 26, 2013
Merged
Conversation
Member
I don't necessarily agree. Adding parentheses is better IMHO: I'd like to get some other feedback on that before you have to re-write your |
Member
|
Given the restriction that |
…achters too long according to pep8. This bulk-fixes every file in the library.
Member
Author
|
Forcibly replaced the old commit with a new one using pelson's suggestion. Also caught a few files I missed last time. |
pelson
added a commit
that referenced
this pull request
Sep 26, 2013
PEP8 fix on every file's from __future__ import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The from future ... line added in #2226 is three charachters too long according to pep8. This bulk-fixes this by breaking the import up into 4 seperate lines.
No matter what every file will need to be touched again, and 4 separate imports seemed better style to me than any other way to break it up.
sedis a handy tool.