FIX: use process_event in dpi changes on macosx backend#23925
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Sep 18, 2022
Merged
FIX: use process_event in dpi changes on macosx backend#23925tacaswell merged 1 commit intomatplotlib:mainfrom
tacaswell merged 1 commit intomatplotlib:mainfrom
Conversation
Avoids resize_event deprecation notices.
jklymak
approved these changes
Sep 17, 2022
Member
jklymak
left a comment
There was a problem hiding this comment.
This works on my machine. Thanks!
Note I didn't test on alternate dpi displays...
Contributor
Author
|
I did swap the figure between different DPI monitors and it worked as expected without deprecation warnings. |
Member
|
Also verified it worked locally. Thank you for the very fast turn around @greglucas ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 18, 2022
…n macosx backend
oscargus
added a commit
that referenced
this pull request
Sep 18, 2022
…925-on-v3.6.x Backport PR #23925 on branch v3.6.x (FIX: use process_event in dpi changes on macosx backend)
|
Hello I don't understand how to use this fix to avoid the error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Avoids
resize_event()deprecation notices that stem from switching dpis or starting with HiDPI. Likely missed while rebasing PR #16931, I tried looking for other potentially deprecated*_event()s hidden in the macos code and I didn't find any at a cursory glance.closes #23921
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).