fix draw_idle reference in NavigationToolbar2#2319
Merged
mdboom merged 1 commit intomatplotlib:masterfrom Aug 28, 2013
Merged
Conversation
NavigationToolbar2 sub-classes do not (all?) have a draw_idle method (strictly speaking, the QT one does not). I assume this should have bounce strait to the canvas, not through the `NavigationToolbar2.draw()` method. Change introduced in 25ff2f7
Member
Author
|
@mdboom Can you take a look at this? Sorry to be a pest. |
Member
|
Pest away! matplotlib issues are too much of a fire hose for me to keep on top of everything 😉 Looks good to me. And just for completeness -- these are the steps to reproduce: In the Qt backend, pan and/or zoom to a new position, then push the back button. |
mdboom
added a commit
that referenced
this pull request
Aug 28, 2013
fix draw_idle reference in NavigationToolbar2
Member
Author
|
Thanks. Sorry for not including better details. |
Member
|
@mdboom Should this be picked into |
Member
|
I think this bug was introduced in 25ff2f7 which is only on master. |
mdboom
added a commit
that referenced
this pull request
Sep 17, 2013
fix draw_idle reference in NavigationToolbar2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NavigationToolbar2 sub-classes do not (all?) have a draw_idle method (strictly speaking, the QT one does not). I assume this should have bounce strait to the canvas, not through the
NavigationToolbar2.draw()method.Change introduced in 25ff2f7