Skip to content

docs: add subplot-mosaic string compact notation#23006

Merged
timhoffm merged 2 commits intomatplotlib:mainfrom
dmatos2012:add-subpltmosaic-docs-notation
May 8, 2022
Merged

docs: add subplot-mosaic string compact notation#23006
timhoffm merged 2 commits intomatplotlib:mainfrom
dmatos2012:add-subpltmosaic-docs-notation

Conversation

@dmatos2012
Copy link
Copy Markdown
Contributor

PR Summary

This PR would close #22917 which adds a small paragraph to the docs that shows the string compact notation for suplot_mosaic. Additionally, I took the liberty to fix a typo and add a section title to the current tutorial that I believe improves readability a bit.

PR Checklist

Tests and Styling

  • [ N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Comment thread tutorials/provisional/mosaic.py Outdated
Copy link
Copy Markdown
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor suggestions, so I will not merge it. If someone disagrees with my suggestions, feel free to merge.

Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
@timhoffm timhoffm merged commit bb3519d into matplotlib:main May 8, 2022
@timhoffm
Copy link
Copy Markdown
Member

timhoffm commented May 8, 2022

Thanks @dmatos2012!

@timhoffm timhoffm added this to the v3.6.0 milestone May 8, 2022
@dmatos2012 dmatos2012 deleted the add-subpltmosaic-docs-notation branch May 9, 2022 07:29
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026

Co-authored-by: David Matos <david@track32.nl>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"ab;cd" missing in subplot_mosaic tutorial

4 participants