Simplify macosx toolbar init.#21717
Merged
greglucas merged 1 commit intomatplotlib:mainfrom Nov 23, 2021
Merged
Conversation
Pass `canvas` as argument to `__init__`, relying on PyArg_ParseTuple to check type (and non-NULL-ness). Also declare some variables closer to point of use, and use NSMakeRect/NSMakeSize to create NSRects and NSSizes.
QuLogic
approved these changes
Nov 22, 2021
greglucas
approved these changes
Nov 23, 2021
Contributor
greglucas
left a comment
There was a problem hiding this comment.
Looks like a nice simplification and the toolbar looks the same for me as before on my local system.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
canvasas argument to__init__, relying on PyArg_ParseTuple tocheck type (and non-NULL-ness).
Also declare some variables closer to point of use, and use
NSMakeRect/NSMakeSize to create NSRects and NSSizes.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).