Clip slider init marker to slider track.#21460
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Oct 26, 2021
Merged
Conversation
This avoids pixelization-related asymmetries, e.g. with the subplot params tool. I'm not sure why self.track needs to be wrapped in a TransformedPatchPath (clip_path seems supposed to also directly support rectangles), but in any case this works...
ianhi
approved these changes
Oct 26, 2021
Contributor
ianhi
left a comment
There was a problem hiding this comment.
Definite improvement nice :)
jklymak
approved these changes
Oct 26, 2021
QuLogic
approved these changes
Oct 26, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 26, 2021
QuLogic
added a commit
that referenced
this pull request
Oct 26, 2021
…460-on-v3.5.x Backport PR #21460 on branch v3.5.x (Clip slider init marker to slider track.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids pixelization-related asymmetries, e.g. with the subplot
params tool.
I'm not sure why self.track needs to be wrapped in a
TransformedPatchPath (clip_path seems supposed to also directly support
rectangles), but in any case this works...
See discussion starting at #19265 (comment) for the original problem.
before:
after:
Not really release-critical for 3.5, but I'll still milestone it there as it goes with #19265. Feel free to remilestone.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).