Skip to content

Break links between twinned axes when removing#21076

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
dstansby:twin-remove
Sep 14, 2021
Merged

Break links between twinned axes when removing#21076
tacaswell merged 1 commit intomatplotlib:masterfrom
dstansby:twin-remove

Conversation

@dstansby
Copy link
Copy Markdown
Member

PR Summary

Fixes #18925. This doesn't reset the original Axes' locator/formatter which requires a much larger change, but at least calling remove() doesn't error with this PR.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@dstansby dstansby added this to the v3.5.0 milestone Sep 14, 2021
@tacaswell
Copy link
Copy Markdown
Member

and @dstansby may have just set a land-speed record for 2 reviews + merge!

timhoffm added a commit that referenced this pull request Sep 14, 2021
…076-on-v3.5.x

Backport PR #21076 on branch v3.5.x (Break links between twinned axes when removing)
tacaswell added a commit that referenced this pull request Oct 20, 2021
FIX: Break links between twinned axes when removing
@dstansby dstansby deleted the twin-remove branch December 28, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing axes created by twiny() leads to an error

3 participants